Add a credit types field #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawaiigal
force-pushed
the
credit-types-field
branch
from
8ee7406
to
699362a
Compare
hawaiigal
force-pushed
the
credit-types-field
branch
from
77146ff
to
4b678f9
Compare
oliverchang
reviewed
Feb 1, 2023
hawaiigal
requested review from
oliverchang
and removed request for
chrisbloom7 and
rsc
chrisbloom7
reviewed
Feb 2, 2023
hawaiigal
requested review from
chrisbloom7 and
oliverchang
and removed request for
oliverchang and
chrisbloom7
chrisbloom7
approved these changes
Feb 6, 2023
oliverchang
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Indeed, thank you @hawaiigal !!
This LGTM, with just one more nit. I'll also ask the remaining OSV-Schema maintainer (@rsc) to give his signoff on this.
rsc
reviewed
Feb 7, 2023
Signed-off-by: Kailani Chu <hawaiigal@github.com>
Signed-off-by: Kailani Chu <hawaiigal@github.com>
Signed-off-by: Kailani Chu <hawaiigal@github.com>
Signed-off-by: Kailani Chu <hawaiigal@github.com>
Signed-off-by: Kailani Chu <hawaiigal@github.com>
hawaiigal
force-pushed
the
credit-types-field
branch
from
73f5cfd
to
6aacd0e
Compare
oliverchang
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Thanks! I've also checked with @rsc and gotten his approval offline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #85, we'd like to propose these changes to the OSV schema to add credit types/roles that correspond to those defined by the MITRE CVE schema.
Would appreciate any feedback or proposed changes!