New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRAN+Bioconductor ecosystems #176
Conversation
I think it's okay to mark this as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Co-authored-by: Tyler Finethy <tylfin@gmail.com> Signed-off-by: Michael Chirico <michaelchirico4@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks!
docs/schema.md
Outdated
<ul> | ||
<li>How to contribute: <a href="https://github.com/RConsortium/r-advisory-database#readme">https://github.com/RConsortium/r-advisory-database#readme</a></li> | ||
<li>Source URL: <code>https://osv.dev/vulnerability/<ID></code></li> | ||
<li>OSV Formatted URL: <code>https://github.com/RConsoritum/r-advisory-database/<package>/<ID>.yaml</code> (unofficial)</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the URL
<li>OSV Formatted URL: <code>https://github.com/RConsoritum/r-advisory-database/<package>/<ID>.yaml</code> (unofficial)</li> | |
<li>OSV Formatted URL: <code>https://github.com/RConsortium/r-advisory-database/<package>/<ID>.yaml</code> (unofficial)</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, does the constructed URL work though? E.g.
https://github.com/RConsortium/r-advisory-database/readxl/RSEC-2023-0.yaml
would not lead to the advisory if I'm not mistaken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work directly:
<li>OSV Formatted URL: <code>https://github.com/RConsoritum/r-advisory-database/<package>/<ID>.yaml</code> (unofficial)</li> | |
<li>OSV Formatted URL: <code>https://raw.githubusercontent.com/RConsortium/r-advisory-database/main/vulns/<package>/<ID>.yaml</code></li> |
For example https://raw.githubusercontent.com/RConsortium/r-advisory-database/main/vulns/readxl/RSEC-2023-0.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the link here.
Signed-off-by: Oliver Chang <oliverchang@users.noreply.github.com>
<ul> | ||
<li>How to contribute: <a href="https://github.com/RConsortium/r-advisory-database#readme">https://github.com/RConsortium/r-advisory-database#readme</a></li> | ||
<li>Source URL: <code>https://osv.dev/vulnerability/<ID></code></li> | ||
<li>OSV Formatted URL: <code>https://github.com/RConsortium/r-advisory-database/blob/main/<package>/<ID>.yaml</code> (unofficial)</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oliverchang I think this is still wrong, missing /vulns
in the path :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, thanks for catching.
Can you please raise a PR to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, thanks for catching.
Can you please raise a PR to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll push it when I get a minute.
Closes #175.
I didn't quite understand "Source URL" vs. "OSV Formatted URL" so I took a guess.
cc @tylfin as upstream maintainer. I marked this as "unofficial" despite R Consortium backing, please CMIIW.