Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events requirements: recommend the use of fixed over limit #221

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

zacchiro
Copy link
Contributor

Rationale: reduce the amount of false negatives in commits belonging to branches forked in-between introduced and fixed/limit.

Closes #216.

@zacchiro zacchiro force-pushed the feature/rec-fixed-over-limit branch 2 times, most recently from 1e9b386 to a1abf6e Compare January 16, 2024 12:35
Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super sorry for the late review!

docs/schema.md Outdated Show resolved Hide resolved
docs/schema.md Outdated Show resolved Hide resolved
Rationale: reduce the amount of false negatives in commits belonging to
branches forked in-between `introduced` and `fixed`/`limit`.

Closes ossf#216.

Signed-off-by: Stefano Zacchiroli <zack@upsilon.cc>
Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here. This LGTM!

@oliverchang oliverchang merged commit 44ee179 into ossf:main Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling of cherry picks in the specification
2 participants