Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Go examples. #76

Merged
merged 4 commits into from Sep 6, 2022
Merged

Clarify Go examples. #76

merged 4 commits into from Sep 6, 2022

Conversation

oliverchang
Copy link
Contributor

@oliverchang oliverchang commented Aug 9, 2022

affected.package.name for Go entries should point to the module, not
to the package import path.

Point to the Go vulnerability database documentation instead of inlining the examples in the spec.

`affected.package.name` for Go entries should point to the module, not
to the package import path.
@oliverchang oliverchang requested a review from rsc August 9, 2022 04:57
Copy link

@rsc rsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julieqiu should be able to correct and or confirm the main Go repository example.

docs/schema.md Outdated
"affected": [
{
"package": {
"name": "std",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Go security team is still deciding on what this name will be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated everything here to point to Go documentation instead. PTAL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julieqiu fyi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsc friendly ping for review, thanks!

docs/schema.md Outdated Show resolved Hide resolved
Signed-off-by: Oliver Chang <oliverchang@users.noreply.github.com>
Copy link

@rsc rsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks.

@oliverchang oliverchang merged commit adaecb9 into main Sep 6, 2022
@oliverchang oliverchang deleted the clarify-go branch September 6, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants