New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify Go examples. #76
Conversation
`affected.package.name` for Go entries should point to the module, not to the package import path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julieqiu should be able to correct and or confirm the main Go repository example.
docs/schema.md
Outdated
"affected": [ | ||
{ | ||
"package": { | ||
"name": "std", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Go security team is still deciding on what this name will be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated everything here to point to Go documentation instead. PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julieqiu fyi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rsc friendly ping for review, thanks!
Signed-off-by: Oliver Chang <oliverchang@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks.
affected.package.name
for Go entries should point to the module, notto the package import path.
Point to the Go vulnerability database documentation instead of inlining the examples in the spec.