Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strace parsing: fix regex issue when unlink syscall does not have path #970

Merged
merged 2 commits into from
Nov 16, 2023
Merged

strace parsing: fix regex issue when unlink syscall does not have path #970

merged 2 commits into from
Nov 16, 2023

Conversation

maxfisher-g
Copy link
Contributor

The unlink parsing regex did not support cases where unlink fails due to a nonexisting path, and so the strace log line had a missing path:

[ 23: 23] cmake X unlink(0x7f234e5bd500 ) = 0 (0x0) errno=2 (no such file or directory) (667ns)

Issue highlighted by roboflex-visualization package on pypi

@maxfisher-g
strace parsing: fix regex issue when unlink syscall does not have path
126c7e4 
Signed-off-by: Max Fisher <maxfisher@google.com>
@maxfisher-g maxfisher-g merged commit 86acaa5 into main Nov 16, 2023
11 checks passed
@maxfisher-g maxfisher-g deleted the strace_parsing_unlink_bug branch November 16, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebbrown calebbrown calebbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxfisher-g @calebbrown