Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Fix some diffs between Golang and current action #431

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

azeemshaikh38
Copy link
Contributor

Fixes 2 diffs that currently show up in Golang action results vs. the current bash one:

  • Inject Scorecard version and commitSHA into Golang action through ldflags
  • Set showDetails to true in Golang action.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #431 (e868b4a) into main (7ab69b4) will increase coverage by 0.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   63.88%   64.54%   +0.65%     
==========================================
  Files           4        4              
  Lines         216      220       +4     
==========================================
+ Hits          138      142       +4     
  Misses         69       69              
  Partials        9        9              
Impacted Files Coverage 螖
options/options.go 87.59% <100.00%> (+0.39%) 猬嗭笍

Makefile Show resolved Hide resolved
@azeemshaikh38 azeemshaikh38 merged commit 80c928c into main Jun 8, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/golang-bug branch June 8, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants