Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added fixes for linters #128

Closed
wants to merge 2 commits into from
Closed

added fixes for linters #128

wants to merge 2 commits into from

Conversation

gaonkar-adi-wipro
Copy link

Commits:

  • added lint error fixes : fixes for lint errors
  • temporarily enable or disable eslint check for console : added no-console disable exception

@gaonkar-adi-wipro gaonkar-adi-wipro mentioned this pull request Jun 27, 2022
Open
@azeemshaikh38
Copy link
Contributor

I'm not comfortable updating the scorecards-site code yet because we don't have enough tests for it and we are currently in the process of untangling some deployment issues we are seeing with the code. Apologies about the mis-wording in #104 - I was referring to fixing linter errors in the Golang code and have updated the issue to fix my mistake.

Thanks for your PR and highly appreciate your contribution to the project. However, I apologize but I'm going to close this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaonkar-adi-wipro @azeemshaikh38