Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Enhance and surface imposter commit errors. #438

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

spencerschrock
Copy link
Contributor

Follow up of #389. The original PR didn't wrap the error in the new verification error which was introduced in #408.

So when a workflow was rejected for having an imposter commit, the user got this message:

error processing signature: http response 500, status: 500 Internal Server Error, error: {"code":500,"message":"something went wrong and we are looking into it.

This PR wraps the imposter commit message so the error is surfaced. The error message also now includes the ref which triggered the warning, so the user doesn't need to guess/check.

error processing signature: http response 400, status: 400 Bad Request, error: {"code":400,"message":"workflow verification failed: imposter commit: deadbeef088af7c0dc8046f3ac9a8f4148492a95 does not belong to step-security/harden-runner, see https://github.com/ossf/scorecard-action#workflow-restrictions for details."}

Signed-off-by: Spencer Schrock <sschrock@google.com>
@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for ossf-scorecard canceled.

Name Link
🔨 Latest commit e4e9ccd
🔍 Latest deploy log https://app.netlify.com/sites/ossf-scorecard/deploys/64b6c746792e13000872471e

@spencerschrock spencerschrock merged commit 2a9c0f9 into ossf:main Jul 18, 2023
12 checks passed
@spencerschrock spencerschrock deleted the fix/imposter-commit-error branch July 18, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants