Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search form when uri not provided #467

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

evankanderson
Copy link
Contributor

This came up during the OpenSSF Scorecards & Best Practices meeting -- the "install nothing" scorecards are great, but it would be even better to make them easier to find...

@netlify
Copy link

netlify bot commented Sep 7, 2023

👷 Deploy request for ossf-scorecard pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 77502d0

@evankanderson
Copy link
Contributor Author

A follow-on would be to link to this viewer from the ossf/scorecards repo with something like the following image and an invitation to check out your own project:

image

Signed-off-by: Evan Anderson <evan@stacklok.com>
@evankanderson
Copy link
Contributor Author

@spencerschrock -- can you review?

Copy link
Contributor

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled the development preview at:
https://deploy-preview-467--ossf-scorecard.netlify.app/viewer/

Can take another look later.

scorecards-site/static/viewer/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You'll need to DCO all commits before I can get this in:

Commit sha: b9f0bd3, Author: Evan Anderson, Committer: Evan Anderson; The sign-off is missing.

Instructions on fixing it can be found with the bot:

https://github.com/ossf/scorecard-webapp/pull/467/checks?check_run_id=16963946201

scorecards-site/static/viewer/index.html Outdated Show resolved Hide resolved
Signed-off-by: Evan Anderson <evan@stacklok.com>
@evankanderson
Copy link
Contributor Author

evankanderson commented Sep 21, 2023

Fixed the DCO as well, and re-merged the upstream changes.

@spencerschrock spencerschrock merged commit 0131f4c into ossf:main Sep 21, 2023
7 checks passed
@spencerschrock
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants