🐛 fallback to releases/v1 branch for codeql-action. #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
✅ Deploy Preview for ossf-scorecard canceled.
|
spencerschrock
requested review from
a team,
justaugustus and
laurentsimon
and removed request for
a team
laurentsimon
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current strategy of imposter commits (#389) doesn't work perfectly for old release branches. One commit that's being flagged is this one: github/codeql-action@54d8b0d.
It belongs to
releases/v1which is divergent from themainbranch. The search approach mentioned in #389 doesn't seem to catch this commit either, and there still isn't an easy API call for "does this commit belong to this repo", so I'm proposing a manual fallback toreleases/v1if the repo is codeql-action. (perhaps this comparison should be case insensitive though)