Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: LGTM is going away #2259

Closed
wenottingham opened this issue Sep 13, 2022 · 1 comment · Fixed by #2339
Closed

BUG: LGTM is going away #2259

wenottingham opened this issue Sep 13, 2022 · 1 comment · Fixed by #2339
Labels
kind/bug Something isn't working

Comments

@wenottingham
Copy link
Contributor

Describe the bug
The SAST check states in its docs (and in the code) that it checks for CodeQL (github-code-scanning), LGTM and SonarCloud in the recent (~30) merged PRs, or the use of "github/codeql-action" in a GitHub workflow.

LGTM is being shut down at the end of December, and is no longer accepting new signups. See https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/ for details.

The checks can probably still check for LGTM, but the docs should probably clarify that it's not something new users should try.

Reproduction steps
Steps to reproduce the behavior:

  1. Look at SAST check docs
  2. Open up the list of services

Expected behavior
All active services used, no deprecated or being-shut-down services suggested.

Additional context

@wenottingham wenottingham added the kind/bug Something isn't working label Sep 13, 2022
@naveensrinivasan
Copy link
Member

@wenottingham Thank you! Would you be interested in doing a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants