Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate our use of "golang.org/x/tools/go/vcs" (deprecated) #3262

Closed
spencerschrock opened this issue Jul 12, 2023 · 1 comment · Fixed by #3269
Closed

Evaluate our use of "golang.org/x/tools/go/vcs" (deprecated) #3262

spencerschrock opened this issue Jul 12, 2023 · 1 comment · Fixed by #3269
Labels
dependencies Pull requests that update a dependency file

Comments

@spencerschrock
Copy link
Contributor

This will serve as a tracking issue, as this package is deprecated now and triggering linter issues. I don't expect the vanity import behavior to change, so I'll be silencing the linter for now, with a link to this issue.

@spencerschrock spencerschrock added the dependencies Pull requests that update a dependency file label Jul 12, 2023
@spencerschrock
Copy link
Contributor Author

Long term, we should probably migrate to go list as we already shell out to go list in other spots in that part of the code, so it wouldn't introduce a new dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant