Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dangerous CI #3630

Open
laurentsimon opened this issue Oct 30, 2023 · 4 comments
Open

Feature: dangerous CI #3630

laurentsimon opened this issue Oct 30, 2023 · 4 comments
Labels

Comments

@laurentsimon
Copy link
Contributor

Same as dangerous workflows, but for other CI. See https://divyanshu-mehta.gitbook.io/researchs/hijacking-cloud-ci-cd-systems-for-fun-and-profit

@spencerschrock spencerschrock added the kind/new-check New check for scorecard label Oct 31, 2023
@raghavkaul
Copy link
Contributor

This is a cool and clever exploit, I think scorecard should try to check this by finding the build trigger in GitHub actions or by reading the configuration of the Cloud builder (AWS, GCP, etc.) Once we have the config we'd see who can trigger a build with arbitrary code and ensure that that's maintainers only or requires maintainer approval. We might need AWS/GCP creds to do it. But I think it'd be an entirely new check, like Dangerous-CI-Triggers or something similar.

Btw, my thinking here is different from #3629 because this is more about the builder/it can be remediated by changing SCM settings/workflow settings and less about scanning AWS IAM, which is external to the SCM.

Copy link

This issue is stale because it has been open for 60 days with no activity.

@laurentsimon
Copy link
Contributor Author

not stale

Copy link

This issue has been marked stale because it has been open for 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog - New Checks
Development

No branches or pull requests

3 participants