Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should probes have their own raw data and supported request types? #3718

Open
spencerschrock opened this issue Dec 7, 2023 · 0 comments
Open

Comments

@spencerschrock
Copy link
Contributor

In this PR we have the following snippet:

	enabledChecks, err := policy.GetEnabled(pol, o.Checks(), requiredRequestTypes)
	if err != nil {
		return fmt.Errorf("GetEnabled: %w", err)
	}

+	enabledProbes := o.Probes()

Probes currently collect their raw data from the underlying checks, so in the current implementation they would require similar requiredRequestTypes (e.g. checker.CommitBased or checker.FileBased).

Since probes are more granular, these probes may not have the same restrictions as the checks. E.g. a probe may operate on file only content, whereas the check its associated with might have other probes that need more than file content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant