Removed duplicated text and added commas after conditional clauses #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"may require" was repeated Signed-off-by: Andrew Johnson <106950101+Andrew-Jeffrey-Johnson@users.noreply.github.com>
Signed-off-by: Andrew Johnson <106950101+Andrew-Jeffrey-Johnson@users.noreply.github.com>
docs/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.md
Outdated
Show resolved
Hide resolved
|
Thanks! Overall looks great. I did find a minor tweak, a "..." needs to restored. That's the conventional way to indicate the elision of some text, and since text is elided there, it's important to retain the "...". |
Signed-off-by: Andrew Johnson <106950101+Andrew-Jeffrey-Johnson@users.noreply.github.com>
|
My apologies! I've restored the ellipsis. Everything should be good now. |
|
Definitely cleans things up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read this lovely guide, and I noticed some duplicated text and a few missing commas. I've removed the duplicate text and added commas after some conditional clauses. These changes do not alter the meaning of the guide.
Thank you for making this guide! It was a joy to read, and I want to help improve it.