Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Publishers for All Package Repositories #43

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Jul 3, 2024

Adds the guide for "Trusted Publishers for All Package Repositories. This document was generated from this Google doc.

Closes #42

Signed-off-by: Seth Michael Larson <seth@python.org>
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed some backticks on my previous review but otherwise LGTM!

docs/trusted-publishers-for-all-package-repositories.md Outdated Show resolved Hide resolved
Copy link
Contributor

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you for your hard work here @sethmlarson! I've left a few small nitpicks 🙂

Copy link
Member

@steiza steiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to read though this in detail, but minor request to add links to docs/index.md (then it'll show up on https://repos.openssf.org/) and README.md; see for example https://github.com/ossf/wg-securing-software-repos/pull/37/files.

sethmlarson and others added 2 commits July 5, 2024 09:10
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Signed-off-by: Seth Michael Larson <sethmichaellarson@gmail.com>
Co-authored-by: William Woodruff <william@yossarian.net>
Signed-off-by: Seth Michael Larson <sethmichaellarson@gmail.com>
sethmlarson and others added 2 commits July 8, 2024 07:08
Co-authored-by: Fredrik Skogman <kommendorkapten@github.com>
Signed-off-by: Seth Michael Larson <sethmichaellarson@gmail.com>
Signed-off-by: Seth Michael Larson <seth@python.org>
Signed-off-by: Seth Michael Larson <seth@python.org>
@sethmlarson
Copy link
Contributor Author

@steiza Added the link to docs/index.md in 0712203

@sethmlarson sethmlarson requested a review from steiza July 8, 2024 14:01
Co-authored-by: William Woodruff <william@yossarian.net>
Signed-off-by: Seth Michael Larson <sethmichaellarson@gmail.com>
Copy link
Member

@steiza steiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo / phrasing suggestions

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
Co-authored-by: Zach Steindler <steiza@github.com>
Signed-off-by: Seth Michael Larson <sethmichaellarson@gmail.com>
@di
Copy link
Member

di commented Jul 11, 2024

Thank you @sethmlarson! ✨

@di di merged commit ba51c33 into ossf:main Jul 11, 2024
1 check passed
@sethmlarson sethmlarson deleted the trusted-publishers-guide branch July 11, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create "Trusted Publishing for All Package Repositories" Guide
6 participants