Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MP3: Fix bug for TS or HLS with mp3 codec. v4.0.269 (#296) #3333

Merged
merged 4 commits into from
Dec 25, 2022
Merged

MP3: Fix bug for TS or HLS with mp3 codec. v4.0.269 (#296) #3333

merged 4 commits into from
Dec 25, 2022

Conversation

winlinvip
Copy link
Member

@winlinvip winlinvip commented Dec 24, 2022 •
edited
Loading

  1. Refresh HLS audio codec if changed in stream.
  2. Refresh TS audio codec if changed in stream.
  3. Fix mp3 demux bug in SrsFormat::audio_mp3_demux.
  4. Use 3(MPEG1) not 4(MPEG2) as PMT stream type, follow FFmpeg.
  5. MP3: Update utest for mp3 sample parsing.
  6. MP3: Ignore empty frame sample.
  7. UTest: Fix utest failed, do not copy files.

@winlinvip
MP3: Fix bug for TS or HLS with mp3 codec. v4.0.269 (ossrs#296)
0b54b0e 
1. Refresh HLS audio codec if changed in stream.
2. Refresh TS audio codec if changed in stream.
3. Fix mp3 demux bug in SrsFormat::audio_mp3_demux.
4. Use 3(MPEG1) not 4(MPEG2) as PMT stream type, follow FFmpeg.
@winlinvip winlinvip linked an issue Dec 24, 2022 that may be closed by this pull request
MP3: Support mp3 for RTMP/HLS/HTTP-FLV/HTTP-TS/HLS etc. #296
Closed
14 tasks
This was linked to issues Dec 25, 2022
Play HTTP-TS stream with mp3 audio by VLC/ffplay/H5(srs-player). SRS 4.0.269+ #3334
Closed
Play HLS stream with mp3 audio by VLC/ffplay/H5(srs-player). SRS 4.0.269+ #3337
Closed
@winlinvip winlinvip merged commit 577cd29 into ossrs:4.0release Dec 25, 2022
winlinvip added a commit that referenced this pull request Dec 25, 2022
@winlinvip
Merge branch v4.0.269 into 5.0release
05d7400 
1. MP3: Fix bug for TS or HLS with mp3 codec. v4.0.269 (#296) (#3333)
winlinvip added a commit that referenced this pull request Dec 25, 2022
@winlinvip
Merge branch v5.0.116 into develop
dc07958 
1. MP3: Fix bug for TS or HLS with mp3 codec. v4.0.269 (#296) (#3333)
2. MP3: Add config examples for MP3. #296
3. Script: Refine GitHub actions.
winlinvip added a commit that referenced this pull request Dec 25, 2022
@winlinvip
Merge branch v5.0.116 into develop
b5aaf67 
1. MP3: Fix bug for TS or HLS with mp3 codec. v4.0.269 (#296) (#3333)
2. MP3: Add config examples for MP3. #296
3. Script: Refine GitHub actions.
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Milestone
No milestone
1 participant
@winlinvip