New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for go mod and blackfriday v2 #39
Conversation
Thank you for this! I have a couple of questions. I've also made some changes to the main repo. They don't introduce any merge conflicts, but If you're doing something in the go.mod file that answers the second question, that will show up as a diff if you rebase.
|
Thank you for creating the software and for taking the time to look at this merge request
I think you are right: I should have included both go.mod and go.sum.
Yes I think I settled on the v2 version of blackfriday as a requirement in go.mod. NB: I'm totally fine with you continuing the work on your branch and closing this merge request (I hope it helped in some way). |
Thank you for the contribution – it is helping, and I look forward to being able to upgrade to Blackfriday v2. Can you share your Running the tests, I get an error in
It looks like all these calls in
Is there a Blackfriday flag that controls this? Or…perhaps it is not consequential? (Perhaps the test is overly specific.) I haven't done the research on whether this affects actual site rendering, or just this test. This test also fails. It generates an error. If Blackfriday v2 doesb't accept
|
Generated output from a markdown page in a test site looks good. It is just the test suite that is in error. I'll fix the tests and Skip the one that I don't know how to fix, and merge this now. Again, thank you for the contribution. |
Thank you for your kind words, I'm glad it is helpful.
I just pulled your file and since I'm on Go 1.13 (Ubuntu 20.04) I can't compile as you use "io/fs" which was introduced in 1.16
I noticed this and I don't know a way around it. Maybe Goldmark? I know Hugo switched to this library. It may make sense. In the goldmark readme is stated:
I'm not sure how this would really impact gojekyll though.
I'm not aware of such flag. |
No description provided.