Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require matching architecture for bootable images #656

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

cgwalters
Copy link
Member

@mvo5
Copy link

mvo5 commented Aug 30, 2024

Just to double check my understanding: bootc-image-builder --target-arch is not affected here because bib does the foreign arch container pulling and when we run bootc it is already a "foreign" arch binary(?)

@cgwalters
Copy link
Member Author

Just to double check my understanding: bootc-image-builder --target-arch is not affected here because bib does the foreign arch container pulling and when we run bootc it is already a "foreign" arch binary(?)

That sounds right yes. (Using the term both "target" and "foreign" here is a bit confusing; I think we can just say: bib pulls the image with the target arch, and when we run bootc it's running emulated with the target arch, so this check will pass)

Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters merged commit fe8207f into ostreedev:main Aug 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants