lib/sysroot: Add OSTREE_EX_STAGE_DEPLOYMENTS environment variable #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot, retest this please |
|
@rh-atomic-bot try |
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 9, 2018
For the same reason we do in the rpm-ostree tests. This also made sure the test run worked when I was offline on a plane. Closes: #1583 Approved by: <try>
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 9, 2018
I feel like I'm drowning in a pile of experimental-but-almost-stable features... Anyways, since we made the feature opt-in in rpm-ostree in coreos/rpm-ostree#1352 let's mirror that a bit here with an environment variable so people can play with it more easily. The tests needed some tweaks; specifically we need to reload the status fact after making changes. I'm still a bit uncertain about the Ansible-as-tests. But we add an upgrade test that uses the new environment variable. Closes: #1583 Approved by: <try>
|
💔 Test failed - status-atomicjenkins |
For the same reason we do in the rpm-ostree tests. This also made sure the test run worked when I was offline on a plane.
I feel like I'm drowning in a pile of experimental-but-almost-stable features... Anyways, since we made the feature opt-in in rpm-ostree in coreos/rpm-ostree#1352 let's mirror that a bit here with an environment variable so people can play with it more easily. The tests needed some tweaks; specifically we need to reload the status fact after making changes. I'm still a bit uncertain about the Ansible-as-tests. But we add an upgrade test that uses the new environment variable.
|
OK, this one should be ready for review. My thought is to land this and then do a release. Then the next one can be stabilizing the current experimental APIs. |
jlebon
reviewed
May 10, 2018
| rpm-ostree cleanup -rp | ||
| - import_tasks: ../tasks/query-host.yml | ||
|
|
||
| # Ensure we can unstage |
There was a problem hiding this comment.
In the following test, we can just skip the --stage one before trying to unstage now, right?
There was a problem hiding this comment.
We do a rpm-ostree cleanup -rp above, so there won't be a staged deployment, right? The idea is to keep things relatively clean between tests. Am I understanding you correctly?
|
Ahh yep, I misread the diff. |
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 11, 2018
I feel like I'm drowning in a pile of experimental-but-almost-stable features... Anyways, since we made the feature opt-in in rpm-ostree in coreos/rpm-ostree#1352 let's mirror that a bit here with an environment variable so people can play with it more easily. The tests needed some tweaks; specifically we need to reload the status fact after making changes. I'm still a bit uncertain about the Ansible-as-tests. But we add an upgrade test that uses the new environment variable. Closes: #1583 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like I'm drowning in a pile of experimental-but-almost-stable
features...
Anyways, since we made the feature opt-in in rpm-ostree in
coreos/rpm-ostree#1352
let's mirror that a bit here with an environment variable so people
can play with it more easily.
The tests needed some tweaks; specifically we need to reload the
status fact after making changes. I'm still a bit uncertain
about the Ansible-as-tests.
But we add an upgrade test that uses the new environment variable.