Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: Add --no-merge #2081

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

cgwalters
Copy link
Member

All of the underlying libostree APIs have supported passing NULL
for a merge deployment for...a long time. But we never plumbed
it up into the CLI.

Add a --no-merge option to aid people who want to do a "factory reset":
#1793

@cgwalters
Copy link
Member Author

Argh, state shared across the admin base test into uboot. Let's just make it a separate test.

Copy link
Member

@d4s d4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@d4s
Copy link
Member

d4s commented Apr 22, 2020

/test sanity

All of the underlying libostree APIs have supported passing `NULL`
for a merge deployment for...a long time.  But we never plumbed
it up into the CLI.

Add a `--no-merge` option to aid people who want to do a "factory reset":
ostreedev#1793
@cgwalters
Copy link
Member Author

OK I just squashed in the same fix as coreos/rpm-ostree#2067 here.

@jlebon
Copy link
Member

jlebon commented Apr 22, 2020

Nice!
/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, d4s, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants