Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _ostree_ensure_fsverity reporting of supports in early exit #3244

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix _ostree_ensure_fsverity reporting of supports in early exit #3244

merged 1 commit into from
May 15, 2024

Commits on May 15, 2024

  1. Fix _ostree_ensure_fsverity reporting of supports in early exit 

    If supported_out is passed to _ostree_ensure_fsverity and we
successfully exit early, for example because the file is a symlink, then
*supported_out is not initialized.

This is problematic in the case of ostree_sysroot_update_post_copy(),
because it passes in an uninitialized supported, and on successfull
return of _ostree_ensure_fsverity() it assumes that it is iniialized.

In case supported happened to be initialized to non-zero it will take
this branch:

      if (!supported)
        break; /* If not supported, skip rest */

Which means *all* further objects will not get fs-verity enabled.
    @alexlarsson
    alexlarsson committed May 15, 2024
    Configuration menu
    Copy the full SHA
    083eacd View commit details
    Browse the repository at this point in the history