-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ingame_logins repository #489
Conversation
Will you apply the unset suggestion to all of the currently open PRs or will that be a following PR? Would prefer if it was multiple palletable prs |
|
5dab833
to
f446450
Compare
21f06ff
to
a40f6f1
Compare
i think the rest is good |
app/repositories/ingame_logins.py
Outdated
INSERT INTO ingame_logins (userid, ip, osu_ver, osu_stream, datetime) | ||
VALUES (:userid, :ip, :osu_ver, :osu_stream, NOW()) | ||
""" | ||
params = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah we should also set dict[str, Any]
as the type on each declaration of params
because the default behaviour will be to take the types of the initial definition, which will be more specific (less flexible)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this should only be set on the initial declaration of params - if it's redefined in the same function ,it should not have the type annotation
mypy will point this out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u can see it in the other repos from master after #501
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls apply to all prs as well
0c11d8d
to
0e0118d
Compare
Describe your changes
Related Issues / Projects
Checklist
make lint
)