Correction de comparaison des SHAs (#1999)

* git repository : previous sha

* fix

* no fallback + gitlab note

* previous_sha to abstract

app/services/git/analyzer.rb

@@ -58,7 +58,7 @@ def previous_path
   end
 
   def previous_sha
-    git_file.previous_sha
+    repository.previous_sha(git_file)
   end
 
   def exists_on_git?
@@ -72,7 +72,7 @@ def exists_on_git?
   def synchronized_with_git?
     exists_on_git? &&                                           # File exists
     git_file.previous_path == git_file.path &&                  # at the same place
-    repository.git_sha(git_file.path) == git_file.previous_sha  # with the same content
+    repository.git_sha(git_file.path) == previous_sha  # with the same content
   end
-  
+
 end

app/services/git/providers/abstract.rb

@@ -37,6 +37,10 @@ def push(commit_message)
     raise NotImplementedError
   end
 
+  def previous_sha(git_file)
+    git_sha(git_file.previous_path)
+  end
+
   def computed_sha(string)
     raise NotImplementedError
   end

app/services/git/providers/github.rb

@@ -107,15 +107,7 @@ def computed_sha(string)
   def git_sha(path)
     return if path.nil?
     # Try to find in stored tree to avoid multiple queries
-    return tree_item_at_path(path)&.dig(:sha)
-    begin
-      # The fast way, with no query, does not work.
-      # Let's query the API.
-      content = client.content repository, path: path
-      return content[:sha]
-    rescue
-    end
-    nil
+    tree_item_at_path(path)&.dig(:sha)
   end
 
   def valid?

app/services/git/providers/gitlab.rb

@@ -61,6 +61,7 @@ def computed_sha(string)
   end
 
   # https://gitlab.com/gitlab-org/gitlab/-/issues/23504
+  # TODO : Il faudrait, comme sur GitHub, stocker le tree pour éviter N requêtes pour N objets.
   def git_sha(path)
     begin
       file = find path

app/services/git/repository.rb

@@ -38,6 +38,10 @@ def computed_sha(string)
     provider.computed_sha(string)
   end
 
+  def previous_sha(git_file)
+    provider.previous_sha(git_file)
+  end
+
   def git_sha(path)
     provider.git_sha path
   end