Correction de comparaison des SHAs #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebouChu
requested review from
arnaudlevy,
pabois,
alexisben and
Olivia206
as code owners
pabois
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
À la synchronisation, quand on analyse un fichier, on compare 2 SHAs :
Pour le previous_sha, on se basait uniquement sur l'attribut de l'objet GitFile. Cependant, lors des problèmes de race conditions, cela a engendré des previous_sha en DB qui ne correspondait pas à la valeur réelle sur Git.
Étant donné qu'on récupère l'intégralité du tree depuis GitHub lors de la synchronisation, on peut récupérer le véritable previous_sha depuis celui-ci avec le path du fichier.
Pour GitLab, on a une méthode qui permet de récupérer le sha d'un fichier distant depuis son path, on passe également par cette méthode.
Il faudrait aussi récupérer le tree car actuellement, pour 5 fichiers, cela engendre 5 appels API contre 1 seul pour GitHub.