Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce FileInfo #78

Merged
merged 6 commits into from
May 31, 2023
Merged

Introduce FileInfo #78

merged 6 commits into from
May 31, 2023

Conversation

reinsch82
Copy link
Contributor

@reinsch82 reinsch82 commented May 22, 2023 •
edited by sbrannen
Loading

I hereby agree to the terms of the Open Test Alliance Contributor License Agreement.

@reinsch82 reinsch82 changed the title Donat/file comparison failure Add FileInfo May 22, 2023
@reinsch82 reinsch82 force-pushed the donat/file-comparison-failure branch from 5147b0d to 47f3548 Compare May 22, 2023 09:34
@reinsch82 reinsch82 force-pushed the donat/file-comparison-failure branch from 47f3548 to 66698d1 Compare May 22, 2023 12:09
@reinsch82 reinsch82 requested a review from leonard84 May 22, 2023 12:09
sbrannen
sbrannen requested changes May 22, 2023
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested some minor changes and raised a few issues for discussion.

src/main/java/org/opentest4j/AssertionFailedError.java Outdated Show resolved Hide resolved
src/main/java/org/opentest4j/FileInfo.java Outdated Show resolved Hide resolved
src/main/java/org/opentest4j/FileInfo.java Show resolved Hide resolved
src/main/java/org/opentest4j/FileInfo.java Outdated Show resolved Hide resolved
src/main/java/org/opentest4j/FileInfo.java Outdated Show resolved Hide resolved
src/main/java/org/opentest4j/FileInfo.java Outdated Show resolved Hide resolved
src/main/java/org/opentest4j/FileInfo.java Outdated Show resolved Hide resolved
src/test/java/org/opentest4j/FileInfoTest.java Outdated Show resolved Hide resolved
src/test/java/org/opentest4j/FileInfoTest.java Outdated Show resolved Hide resolved
src/main/java/org/opentest4j/FileInfo.java Show resolved Hide resolved
@sbrannen sbrannen changed the title Add FileInfo Introduce FileInfo May 22, 2023
marcphilipp and others added 2 commits May 23, 2023 07:19
@marcphilipp @donat @reinsch82
Add FileInfo
14c751a 
Co-authored-by: Donát Csikós <donat@gradle.com>
@reinsch82
Add javadoc for FileInfo
88cc2bd
@reinsch82 reinsch82 force-pushed the donat/file-comparison-failure branch 2 times, most recently from 2430258 to 5b82904 Compare May 25, 2023 12:24
@reinsch82 reinsch82 force-pushed the donat/file-comparison-failure branch from 5b82904 to 6690b1b Compare May 25, 2023 12:28
@reinsch82 reinsch82 requested a review from sbrannen May 25, 2023 12:29
@reinsch82 @marcphilipp
Update AssertionFailedError javadoc
826b535 
Co-authored-by: Marc Philipp <marc@gradle.com>
sbrannen
sbrannen approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested changes.

This looks much better now.

Any additional polishing can be done after merging into main.

@reinsch82
Remove constructor
a561f8c 
Isn't important.
@reinsch82 reinsch82 force-pushed the donat/file-comparison-failure branch from 365cf55 to a561f8c Compare May 31, 2023 07:54
@reinsch82 reinsch82 force-pushed the donat/file-comparison-failure branch from d5bff32 to 6f2aa6d Compare May 31, 2023 08:44
@marcphilipp marcphilipp added this to the 1.2.0 milestone May 31, 2023
@marcphilipp marcphilipp merged commit de5e136 into ota4j-team:main May 31, 2023
@marcphilipp marcphilipp modified the milestones: 1.2.0, 1.3.0 May 31, 2023
eolivelli
eolivelli reviewed May 31, 2023
View reviewed changes
Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

jbduncan referenced this pull request May 31, 2023
@marcphilipp
Document potential mutability in Javadoc
5fca4f2
@donat donat mentioned this pull request Jun 7, 2023
Closed
@donat donat deleted the donat/file-comparison-failure branch June 7, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcphilipp marcphilipp marcphilipp approved these changes

@donat donat donat left review comments

@nskvortsov nskvortsov nskvortsov left review comments

@jbduncan jbduncan jbduncan left review comments

@eolivelli eolivelli eolivelli left review comments

@sbrannen sbrannen sbrannen approved these changes

@leonard84 leonard84 Awaiting requested review from leonard84

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
8 participants
@reinsch82 @sbrannen @marcphilipp @donat @nskvortsov @leonard84 @jbduncan @eolivelli