Skip to content

Commit

Permalink
Committed random notes.
Browse files Browse the repository at this point in the history
  • Loading branch information
Forrest L Norvell committed Jun 25, 2013
1 parent fcdf6b8 commit 721849d
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/events.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ function EventEmitter () {
// debugger;
return domainspace.active.get('domain');
},
set : function () {
set : function (domain) {
// debugger;
domainspace.active.set('domain');
domainspace.active.set('domain', domain);
}
});

Expand Down
9 changes: 9 additions & 0 deletions notes/linkages.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Requiring 'domain' causes:

* the event loop to switch to using _nextDomainTick and
_tickDomainCallback.
* EventEmitters to propagate domains as they're instantiated

`domainspace` is the convention for indicating the domain namespace, with the
`domain` property on the contexts created on that namespace being where the
domains live.
16 changes: 16 additions & 0 deletions notes/outstanding.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
* how much of the already-bootstrapped environment does the module need to
replace? E.g. if I update the EE and Domain prototypes, will stdio be fine?
* at instantiation, each Domain creates an accompanying Context and stores
itself as a "domain" on the Context -- what's the easiest way to flip that
inside out and get rid of the containing relationship there?
* how do I get the domains nesting behavior (i.e. exit nested when containing
is exited) into namespaces / contexts?
* Namespace -> Context -> (key,value) adds at least one layer of indirection
to how domains work presently. Is there a cleaner way of handling this?
* I don't need to deal with any of the Timer clearing methods or unref, do I?
* need to do a sweep to make sure all the things that deal with domains are
working properly with namespaces
* What's the simplest way to tie the knot between EEs, timers, domains, and
the event loop?
* none of this is benchmarked yet; need to grab some of the pummel tests and
adapt them to run this stuff

0 comments on commit 721849d

Please sign in to comment.