Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player::queryAdd always picking first slot #2954

Closed
EPuncker opened this issue Apr 21, 2020 · 6 comments · Fixed by #2955
Closed

Player::queryAdd always picking first slot #2954

EPuncker opened this issue Apr 21, 2020 · 6 comments · Fixed by #2955
Labels
bug An issue describing unexpected behavior of code

Comments

@EPuncker
Copy link
Contributor

how to reproduce:

  • have a full container of items:
    2020-04-21 18_48_41-CN=Microsoft Windows, O=Microsoft Corporation, L=Redmond, S=Washington, C=US

  • try to move a meat from the ground to the stack with 20 meat (or to any stack that is not the first)

result: it will move the meat to the first slot, no matter what slot you move it to

curious fact: it works fine moving meats from a stack to another tho, but from outside the container there is the bug

@nekiro
Copy link
Member

nekiro commented Apr 21, 2020

I noticed this too. I believe its client issue, could you try to test that with otc? This only happens if container is full, it will always push index as 1 for some reason.

@EPuncker
Copy link
Contributor Author

EPuncker commented Apr 21, 2020

I noticed this too. I believe its client issue, could you try to test that with otc? This only happens if container is full, it will always push index as 1 for some reason.

just did, same thing 🤔 gonna try rl tibia

@nekiro
Copy link
Member

nekiro commented Apr 21, 2020

I see, so this might be actually bug with auto stack code inside the server, because as far as I know it will always choose the first item that matches the search in this case your index 1 is the one that matches the "query", so maybe even if we have destination supplied it will try to do that. I didn't investigate it's my wild guess right now.

@EPuncker
Copy link
Contributor Author

asdasd

@nekiro
Copy link
Member

nekiro commented Apr 21, 2020

@EPuncker it only happens if top parent of container is tile, am I right?

@nekiro nekiro mentioned this issue Apr 21, 2020
@DSpeichert
Copy link
Member

@EPuncker is that from RL? We can confirm it as a bug then.

@nekiro nekiro added the bug An issue describing unexpected behavior of code label Apr 29, 2020
DSpeichert pushed a commit that referenced this issue Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected behavior of code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants