Auto stack fix

[nekiro]

Fix #2954

[EPuncker]

tested and working like a charm, I can select any stack in the container to move the item to and it wont always chose the first slot

[yamaken93]

For a reason i forget i did it differently:

if (index != INDEX_WHEREEVER) {
    Item* itemFromIndex = getItemByIndex(index);
    if (itemFromIndex) {
        if (itemFromIndex != item && itemFromIndex->equals(item) && itemFromIndex->getItemCount() < 100) {
            *destItem = itemFromIndex;
            return this;
        }
    }
}

[nekiro]

@cristofermartins your code does not consider if itemFromIndex is a cylinder (container) which happens here:

forgottenserver/src/container.cpp

Lines 446 to 451 in 5a8f50b

	Cylinder* subCylinder = dynamic_cast<Cylinder*>(*destItem);
	if (subCylinder) {
	index = INDEX_WHEREEVER;
	*destItem = nullptr;
	return subCylinder;
	}

[yamaken93]

Yeah but no bug will happens since equals won't match the id and moving the item direct to the backpack so it will move inside the backpack stills works.

[nekiro]

@cristofermartins thats nice, also it does ignore the flag "ignoreautostack"

[yamaken93]

The code i posted happens below the autostack flag is checked:

bool autoStack = !hasBitSet(FLAG_IGNOREAUTOSTACK, flags);
bool isStackable = item->isStackable();
if (autoStack && item->isStackable() && item->getParent() != this) {
    if (index != INDEX_WHEREEVER) {
        Item* itemFromIndex = getItemByIndex(index);
        if (itemFromIndex) {
            if (itemFromIndex != item && itemFromIndex->equals(item) && itemFromIndex->getItemCount() < 100) {
                *destItem = itemFromIndex;
                return this;
            }
        }
    }

[nekiro]

@cristofermartins oh I see, so you wrote a bunch of redundant code imo. You have all these things you wrote before that autoStack check and you can just check the destItem variable.

[yamaken93]

Yeah i think its redundant as you said.

[MillhioreBT]

It seems correct, I tried it and it works, if someone else can confirm it it would be much better.