Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug transfering gold to player who doesn't exist in bank NPC #4680

Closed
Coldensjo opened this issue May 14, 2024 · 3 comments · Fixed by #4683
Closed

Bug transfering gold to player who doesn't exist in bank NPC #4680

Coldensjo opened this issue May 14, 2024 · 3 comments · Fixed by #4683
Labels
bug An issue describing unexpected behavior of code priority: high

Comments

@Coldensjo
Copy link
Contributor

Steps to reproduce (include any configuration/script required to reproduce)

  1. Talk to the bank NPC
  2. Say "hi" "transfer 500 playerwhodoesntexist"
  3. Error in console

Expected behaviour

NPC should say "This player does not exist."

Actual behaviour

Nothing happens

Environment

Basic tfs

Reproduction environment

Basic tfs
@EvilHero90
Copy link
Contributor

Can't reproduce this
client_nPcOlf6jTe

@Coldensjo
Copy link
Contributor Author

Try saying "transfer 500 randomname" and not "transfer" "500" "randomname"

@EvilHero90 EvilHero90 added bug An issue describing unexpected behavior of code priority: high labels May 14, 2024
@EvilHero90
Copy link
Contributor

EvilHero90 commented May 14, 2024 •
edited
Loading

Yea this gives an error, I'll include this in #4671
Edit: looking at the source code you are supposed to say it like: transfer 1000 nameofplayer but yea it should not throw an error nonetheless

@EvilHero90 EvilHero90 mentioned this issue May 15, 2024
Merged
3 tasks
@EvilHero90 EvilHero90 linked a pull request May 15, 2024 that will close this issue
Bank.lua fix on transfer if params are shifted #4680 #4683
Merged
3 tasks
EvilHero90 added a commit that referenced this issue May 16, 2024
@EvilHero90
Bank.lua fix on transfer if params are shifted #4680 (#4683)
9ae402c 
- checking now if param 2 is not a number, incase that's true we tell that the player does not exist
- added another check which actually looks if the player is valid before comparing any names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue describing unexpected behavior of code priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bank.lua fix on transfer if params are shifted #4680 EvilHero90/forgottenserver
2 participants
@EvilHero90 @Coldensjo