[Revscriptsys] RevNpcSys version 1.0 (lua npcs / NpcType / new npc system) #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tree handling talkstates - a few bugfixes and corrections
- added callbacks to keywords
- adding storagevalue requirements for easy checks with failure respond function
- added documentation and annotations - split all the functions in different files for better overview and organization
- if you add a callback to a keyword it can return false and also return a string for the failure respond message - changed order of calling functions in events 1) checks callback 2) checks requirements 3) opens shop now we are not opening shop even tho requirements or callback was not correct - added an example usage of callback in handler.lua - corrections in documentation
- constants.lua adding more messages to MESSAGE_LIST - events.lua fixing a problem where the player could say keywords without greeting the npc first added requirements added a `help` default keyword, which will tell the player to which keywords the npc responds - general better documentation - added modules.lua - added requirements.lua - added a test example npc data/npc/lua/#test.lua
- removed `requireStorage` it's redundant as we have the same in requirements - renamed `setGreetRespond` -> `setGreetResponse` `setFarewellRespnd` -> `setFarewellResponse` - added `setGreetKeywords` `setFarewellKeywords`
- fixed annotations
- moved everything to NpcType - we don't create a NpcScriptInterface per npc created rather just load it by each NpcType -
- we are sharing one NpcScriptInterface instead of creating one for each npc
forgot to include Co-Authored-By: Sarah Wesker <sarahelizabetwesker@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
EvilHero90
added
enhancement
- `keyword` and `respond` support now multiple inserts via table - if there is multiple keywords for the same outcome we just point to one metatable instead of creating several (memory efficient)
- made all the get functions of `NpcType` into const - added `NpcType.onMove`,`NpcType.onPlayerCloseChannel` and `NpcType.onPlayerEndTrade` with their callback functions - correction for lua npcs at ~NpcEventsHandler() which caused them to have no scripting interface when an npc was removed and respawned
- you can now use item names aswell for shop items
- we are sending errors in console if the item does not exist or if it doesn't have the property to be able to pick it up
- adding `NpcsHandler:farewell()` function to release focus on yourself on certain keywords. - fixed correct order of trying to get a failureResponse when working with callbacks - shows an error message if there is no set failureResponse
- changing npcEventHandler shared_ptr to unique_ptr
ranisalt
reviewed
May 21, 2024
ranisalt
reviewed
May 21, 2024
Feel free to just review the .cpp/h changes, those are mostly the critical changes, we still have the old npc system if something shouldn't correctly work at some point I can just push fixes and increase the version |
ranisalt
reviewed
May 22, 2024
ranisalt
requested changes
May 22, 2024
- removed info struct and moved everything to public
- delay is now global and was removed out of the voices table, default delay is 30s and the delay can be set at handler:talk(voices, delay) - we check now if the voice it wants to say is the same as the last voice and then roll again until it finds another one if there are several to choose from
This now saves the player who was sending the money regardless if the receiver is online/offline and does a db query for the receiver to keep the bank balance in sync
ranisalt
previously approved these changes
May 25, 2024
There was a problem hiding this comment.
LGTM, let's see what @MillhioreBT and @ramon-bernardo have to say
ramon-bernardo
approved these changes
May 26, 2024
renaming folder from evilnpcsystem to revnpcsys
ranisalt
previously approved these changes
May 26, 2024
Co-Authored-By: Sarah Wesker <sarahelizabetwesker@gmail.com>
The npc was not correctly focusing players when they talked to him, this bug is now fixed. Co-Authored-By: Sarah Wesker <sarahelizabetwesker@gmail.com>
now you can check in requirements for certain vocations in order to pass
- added some linter corrections and additions - changed player:getItemCount(id, subType) -> player:getItemCount(id, subType, ignoreEquipped) that way we can exclude equipped items or not - added NpcsHandler:addItems(table--[[,container, inbox]]) we can add a table of items with that, if the player doesn't have enough space or capacity then the items will be send to inbox - added Player.sendInboxItems(self, items, containerId) - re worked onStorageValue callback we can now set a "range" with ex: onStorageValue(1, ">", 10, "<") - re worked requirements (level & storagevalue) checks, they accept now ranged checks aswell level(1, ">=", 9, "<=") storage(10, ">", 50, "<") - changed NpcsHandler:teleport(pos) -> NpcsHandler:teleport(pos, magicEffectFromPos, magicEffectToPos) default is CONST_ME_TELEPORT - added NpcType:health(...) & NpcType:maxHealth(...) functions -added NpcRequirements:items(table) & NpcRequirements:removeItems(table) - added some stuff in constants.lua
EvilHero90
changed the title
EvilHero90
changed the title
EPuncker
reviewed
May 30, 2024
|
Let's go 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Finaly introducing lua npcs with an oop based new npc system.
Both systems lua and xml are now based on NpcType.
This pr doesn't change anything on the already existing xml npcs and jiddos npc system, that's still valid and functional.
Fixed a memory leak regarding xml npcs.
I've included 2 example npcs in data/npc/lua/#test.lua
Issues addressed:
none