Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add player check to pitfall holes #3968

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Conversation

EPuncker
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Added check so only players could trigger them decaying tiles where you step up and fall
Yes, official behavior
Also added a missing pitfall
2022-02-22 07_22_39-12rlmap86 otbm_ - Remere's Map Editor

Issues addressed:

@andersonfaaria

This comment was marked as abuse.

@joseluis2g
Copy link
Contributor

weirdo

@EPuncker
Copy link
Contributor Author

I like that you are bringing some of the corrections from otservbr such as this one opentibiabr/otservbr-global#442

While cherry picking, a good pratice is to reference the original author to give credits. Especially in your case, where you're constantly snobbing the project but it's following it to the point of being able to copy things in a time frame of a few hours.

as you can see in #3966, let me show you a bigger picture:
2022-02-22 14_36_31-avalon otbm_ - Remere's Map Editor

so... no, the world doesn't revolve around your guys code, while I was taking a look at #3966 I noticed my pitfall was not working, but kudos for trying to look relevant.

PS: I never had any issue giving proper credit when applicable as you can see here: #2795

2022-02-22 14_49_56-Meme Generator - Imgflip

@lgrossi
Copy link

lgrossi commented Feb 22, 2022

Well at least the xml we know it's yours. 🤣

@otland otland temporarily blocked andersonfaaria Feb 23, 2022
@DSpeichert DSpeichert merged commit 6c00ed7 into otland:master Feb 24, 2022
Codinablack pushed a commit to Codinablack/forgottenserver that referenced this pull request Apr 5, 2022
EPuncker added a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants