Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed draw well from teleport action #3966

Merged
merged 3 commits into from
Mar 6, 2022
Merged

Removed draw well from teleport action #3966

merged 3 commits into from
Mar 6, 2022

Conversation

EPuncker
Copy link
Contributor

Pull Request Prelude

Changes Proposed

No draw well at all should be teleporting players a floor down, that is not default action and would lead to scenarios like this:
2022-02-22 03_40_09-baiakNFT 8 6

MillhioreBT
MillhioreBT previously approved these changes Feb 22, 2022
@EPuncker EPuncker mentioned this pull request Feb 22, 2022
3 tasks
@omarcopires
Copy link
Contributor

Isn't there a way to check if there's a floor available instead of removing the functionality?

@ranisalt
Copy link
Member

ranisalt commented Feb 24, 2022

@EPuncker can you find one that works and add an actionid, so we can keep this action just as demonstration?

Isn't there a way to check if there's a floor available instead of removing the functionality?

This should be added specifically to each well that needs it, by action instead of itemid

@EPuncker EPuncker mentioned this pull request Feb 25, 2022
3 tasks
@EPuncker EPuncker marked this pull request as draft February 25, 2022 02:46
@EPuncker EPuncker marked this pull request as ready for review March 4, 2022 08:21
@EPuncker
Copy link
Contributor Author

EPuncker commented Mar 4, 2022

@ranisalt ok, ready to go and tested, and the map part was already merged

@omarcopires
Copy link
Contributor

The value is already used in data/lib/core/actionIds
sandHole = 100, -- hidden sand hole

@ranisalt
Copy link
Member

ranisalt commented Mar 5, 2022

It will conflict with sandhole as @omarcopires said, if you use a shovel on the draw well and the ground is sand.

Edit: not sure though, but better safe than sorry

@EPuncker
Copy link
Contributor Author

EPuncker commented Mar 5, 2022

ok fixed

@EPuncker EPuncker merged commit 7df369c into master Mar 6, 2022
@EPuncker EPuncker deleted the EPuncker-patch-1 branch March 6, 2022 16:36
EPuncker added a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants