-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed draw well from teleport action #3966
Conversation
Isn't there a way to check if there's a floor available instead of removing the functionality? |
@EPuncker can you find one that works and add an actionid, so we can keep this action just as demonstration?
This should be added specifically to each well that needs it, by action instead of itemid |
@ranisalt ok, ready to go and tested, and the map part was already merged |
The value is already used in data/lib/core/actionIds |
It will conflict with sandhole as @omarcopires said, if you use a shovel on the draw well and the ground is sand. Edit: not sure though, but better safe than sorry |
ok fixed |
Pull Request Prelude
Changes Proposed
No draw well at all should be teleporting players a floor down, that is not default action and would lead to scenarios like this:
![2022-02-22 03_40_09-baiakNFT 8 6](https://user-images.githubusercontent.com/4684880/155076903-bbee333a-2dc7-4fed-a0b6-79a724b33b44.png)