Cleanup & organize includes and PCH #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranisalt
requested review from
EPuncker,
DSpeichert and
nekiro
and removed request for
DSpeichert
|
Any stats on how much this improved compile time?
That could be worth while to include as a comment in the PCH file as future guidance. |
DSpeichert
reviewed
Mar 17, 2022
src/otpch.h
Outdated
| #include <cstdint> | ||
| #include <fmt/format.h> |
There was a problem hiding this comment.
Suggested change
| #include <fmt/format.h> | |
| #include <fmt/color.h> |
While <fmt/color.h> is only used in one place, it itself includes <fmt/format.h> and therefore would be sufficient.
There was a problem hiding this comment.
Additionally, colors will be available everywhere. I'll do that (or feel free if you have time)
DSpeichert
force-pushed
the
cleanup-includes
branch
from
4864eab
to
3697cd4
Compare
DSpeichert
approved these changes
Mar 18, 2022
3 tasks
EPuncker
pushed a commit
to EPuncker/forgottenserver
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
An effort to clean up includes, reduce header file sizes and make compilation faster. Moves includes not used in .h files to .cpp and forward declares when possible.
Includes in the PCH are required by 3 or more compilation units.