Move all system headers to PCH #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranisalt
requested review from
EPuncker and
DSpeichert
and removed request for
EPuncker
|
@DSpeichert was faster than me, sorry for the second PR :P |
DSpeichert
approved these changes
Mar 18, 2022
nekiro
reviewed
Mar 19, 2022
| #include <vector> | ||
|
|
||
| #if __has_include("luajit/lua.hpp") |
There was a problem hiding this comment.
didn't we drop this __has_include thing for some reason?
There was a problem hiding this comment.
I don't remember exactly, but it could have something to do with the CMAKE's -DUSE_LUAJIT not working right.
2 tasks
EPuncker
pushed a commit
to EPuncker/forgottenserver
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Further improves #4019 by adding all system headers to the precompiled header. According to this and several other sources, every included header that is not expected to change often - that is, usually all system headers - are good candidates.
There is a notable improvement from ~2:40 to less than 2 minutes build in my machine.