Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call onItemMove and Moved from Game:playerEquipItem #4238

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

MillhioreBT
Copy link
Contributor

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Issues addressed: #4193

Copy link
Contributor

@ramon-bernardo ramon-bernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix the problem, looks good!

@EPuncker
Copy link
Contributor

EPuncker commented Nov 4, 2022

great, need to run clang for code style only

@MillhioreBT
Copy link
Contributor Author

great, need to run clang for code style only

It was broken many PRs ago, I don't know when they merged a PR with code without the required format, but it doesn't come from this PR. the downside of merging PR without c-clang is that it propagates through all subsequent PRs.

If you think it's a good idea that I do the c-clang to the whole source, I'll gladly do it right here in this PR, just let me know.

@ranisalt
Copy link
Member

ranisalt commented Nov 4, 2022

@EPuncker we need to do it separately. I don't have this issue locally, format changes nothing, seems to be an issue with the specific version shipped by the OS that runs the action.

@ranisalt ranisalt merged commit bef1137 into otland:master Nov 4, 2022
@MillhioreBT MillhioreBT deleted the equipitem_callevents branch November 4, 2022 19:30
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants