Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support charges and bulk item creation by talkaction #4297

Closed
wants to merge 2 commits into from

Conversation

marmichalski
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Better charges support:
  • Allow to create all items in bulk
    • For example, creating 10 vials of mana fluid would be: /i 2006, 7, 10

Issues addressed: #4156

@EPuncker EPuncker linked an issue Jan 26, 2023 that may be closed by this pull request
2 tasks
@EPuncker EPuncker added the enhancement Increase or improvement in quality, value, or extent label Jan 26, 2023
@MillhioreBT
Copy link
Contributor

I prefer the solution that @EPuncker raised in the issue #4156
image
it is very simple and works.

and:
image

@nekiro
Copy link
Member

nekiro commented Feb 22, 2023

use itemType:hasSubType() method to simplify check for items that require subtype to be used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.4.x enhancement Increase or improvement in quality, value, or extent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_item.lua incorrect charges for amulets/weapons
4 participants