Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_item.lua incorrect charges for amulets/weapons #4156

Closed
2 tasks done
EPuncker opened this issue Jun 8, 2022 · 0 comments · Fixed by #4350
Closed
2 tasks done

create_item.lua incorrect charges for amulets/weapons #4156

EPuncker opened this issue Jun 8, 2022 · 0 comments · Fixed by #4350
Labels
bug An issue describing unexpected behavior of code good first issue Issues that are easy to get started with priority: low Issues with this label won’t have the immediate focus

Comments

@EPuncker
Copy link
Contributor

EPuncker commented Jun 8, 2022

Before creating an issue, please ensure:

  • This is a bug in the software that resides in this repository, and not a
    support matter (use https://otland.net/forums/support.16/ for support)
  • This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

  1. /i strange talisman, 200

Expected behaviour

strange talisman is created with 200 charges

Actual behaviour

strange talisman is created with 100 charges

Environment

create item talkaction seems to not have a handling for items with charges that are not stackable

Possible fix?

2022-06-08 12_00_57-GitHub Desktop
@EPuncker EPuncker added bug An issue describing unexpected behavior of code good first issue Issues that are easy to get started with priority: low Issues with this label won’t have the immediate focus labels Jun 8, 2022
@marmichalski marmichalski mentioned this issue Jan 21, 2023
Closed
3 tasks
@EPuncker EPuncker linked a pull request Jan 26, 2023 that will close this issue
Support charges and bulk item creation by talkaction #4297
Closed
3 tasks
@omarcopires omarcopires mentioned this issue Mar 16, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue describing unexpected behavior of code good first issue Issues that are easy to get started with priority: low Issues with this label won’t have the immediate focus
Projects
None yet
Milestone
No milestone
1 participant
@EPuncker