Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MatrixArea rotations and add tests #4378

Merged
merged 3 commits into from
Apr 8, 2023

Conversation

ranisalt
Copy link
Member

@ranisalt ranisalt commented Apr 6, 2023

Pull Request Prelude

Changes Proposed

Issues addressed:

Fixes an issue where rotating spells using flip() and mirror() would sometimes incorrectly generate the new area with the wrong positions. To ensure this does not happen again, added unit tests checking that the correct positions will or will not get spell effects, and that the center of the area is correctly moved when rotated.

EPuncker
EPuncker previously approved these changes Apr 6, 2023
@ranisalt
Copy link
Member Author

ranisalt commented Apr 7, 2023

Flip, mirror and transpore are correct, but are the wrong functions to use where they are used. Fixed and removed the unused code.

@EPuncker EPuncker merged commit a3e45c3 into otland:master Apr 8, 2023
@omarcopires
Copy link
Contributor

Some errors are being returned when trying to compile on mvs 2022.

  • Master environment, without any changes.
  • Previous commits compile normally.
    I apologize for the mistakes in Portuguese, but it's something like "unresolved external symbol"

image

@ranisalt ranisalt deleted the fix-matrixarea-rotations branch April 8, 2023 22:45
@ranisalt
Copy link
Member Author

ranisalt commented Apr 8, 2023

@omarcopires check #4396 it should fix the problem

@omarcopires
Copy link
Contributor

@omarcopires check #4396 it should fix the problem

works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants