Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ProtocolOutfit const reference #4425

Merged
merged 2 commits into from
Apr 24, 2023
Merged

fix ProtocolOutfit const reference #4425

merged 2 commits into from
Apr 24, 2023

Conversation

MillhioreBT
Copy link
Contributor

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

We now construct a string instead of holding a constant reference to a string.

Issues addressed: #4383

@MillhioreBT MillhioreBT mentioned this pull request Apr 24, 2023
Closed
3 tasks
ranisalt
ranisalt reviewed Apr 24, 2023
View reviewed changes
src/outfit.h Show resolved Hide resolved
ranisalt
ranisalt reviewed Apr 24, 2023
View reviewed changes
src/protocolgame.cpp Outdated Show resolved Hide resolved
@EPuncker EPuncker merged commit 2c85eda into otland:master Apr 24, 2023
12 checks passed
@MillhioreBT MillhioreBT deleted the protocoloutfits branch April 24, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranisalt ranisalt ranisalt approved these changes

@EPuncker EPuncker EPuncker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MillhioreBT @ranisalt @EPuncker