Fix outfit window crash

[maattch]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Issues addressed:
Fix #4383 introduced after the changes in #4079.
Since ProtocolOutfit holds a reference to a string, we cannot pass it directly.

[omarcopires]

Random mount is also a problem in case of gm outfit. Perhaps it should be blocked in this case, or simply remove the gm outfit for good, as it is well known that it has been discontinued by cip.

[MillhioreBT]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Issues addressed: Fix #4383 introduced after the changes in #4079. Since ProtocolOutfit holds a reference to a string, we cannot pass it directly.

How can the crash be reproduced?
because it works normally for me, and PR #4400 fixes the name problem.

Edit:

Ok I found the problem in the podiums, you were right, I didn't do more tests but probably there would also be more problems if there were several players with Access when trying to see the window.

I opened a PR #4425 with some changes that solved the problem, but we have to wait for some expert on the subject to decide if your PR is better or maybe mine. since I do not fully understand regarding this type of optimizations

[maattch]

Closed. A better fix was made in #4425