[Revscriptsys] RevNpcSys version 1.0 (lua npcs / NpcType / new npc system)

data/lib/compat/compat.lua

@@ -132,6 +132,42 @@ do
 	rawgetmetatable("Action").__newindex = ActionNewIndex
 end
 
+do
+	local function NpcTypeNewIndex(self, key, value)
+		if key == "onSay" then
+			self:eventType("say")
+			self:onSay(value)
+			return
+		elseif key == "onDisappear" then
+			self:eventType("disappear")
+			self:onDisappear(value)
+			return
+		elseif key == "onAppear" then
+			self:eventType("appear")
+			self:onAppear(value)
+			return
+		elseif key == "onMove" then
+			self:eventType("move")
+			self:onMove(value)
+			return
+		elseif key == "onPlayerCloseChannel" then
+			self:eventType("closechannel")
+			self:onPlayerCloseChannel(value)
+			return
+		elseif key == "onPlayerEndTrade" then
+			self:eventType("endtrade")
+			self:onPlayerEndTrade(value)
+			return
+		elseif key == "onThink" then
+			self:eventType("think")
+			self:onThink(value)
+			return
+		end
+		rawset(self, key, value)
+	end
+	rawgetmetatable("NpcType").__newindex = NpcTypeNewIndex
+end
+
 do
 	local function TalkActionNewIndex(self, key, value)
 		if key == "onSay" then
@@ -588,8 +624,6 @@ function isPremium(cid) local p = Player(cid) return p and p:isPremium() or fals
 
 STORAGEVALUE_EMPTY = -1
 function Player:getStorageValue(key)
-	print("[Warning - " .. debug.getinfo(2).source:match("@?(.*)") .. "] Invoking Creature:getStorageValue will return nil to indicate absence in the future. Please update your scripts accordingly.")
-
 	local v = Creature.getStorageValue(self, key)
 	return v or STORAGEVALUE_EMPTY
 end

data/lib/core/player.lua

@@ -158,6 +158,8 @@ function Player.transferMoneyTo(self, target, amount)
 	end
 
 	self:setBankBalance(self:getBankBalance() - amount)
+	-- incase server crashes that we do not duplicate money
+	db.query("UPDATE `players` SET `balance` = " .. self:getBankBalance() .. " WHERE `id` = '" .. self:getGuid() .. "'")
 	return true
 end
 

data/npc/lib/evilnpcsystem/constants.lua

@@ -0,0 +1,113 @@
+--[[
+    >> Constants <<
+
+    Description:
+        - This file contains all the constants used in the NPC System.
+]]
+
+-- MESSAGE_TAGS
+---@class MESSAGE_TAGS
+---@type table<string, table<string, string|number|function>>
+MESSAGE_TAGS = {
+    playerName = { tag = "|PLAYERNAME|", func = function(params) return params.playerName or "" end },
+    playerLevel = { tag = "|PLAYERLEVEL|", func = function(params) return params.playerLevel or "" end },
+    itemCount = { tag = "|ITEMCOUNT|", func = function(params) return params.amount or "" end },
+    totalCost = { tag = "|TOTALCOST|", func = function(params) return params.total or "" end },
+    itemName = { tag = "|ITEMNAME|", func = function(params) return params.itemName or "" end },
+    storageKey = { tag = "|STORAGEKEY|", func = function(params) return params.storage and params.storage.key or "" end },
+    storageValue = { tag = "|STORAGEVALUE|", func = function(params) return params.storage and params.storage.value or "" end }
+}
+
+-- MESSAGE_LIST
+---@class MESSAGE_LIST
+---@type table<string, string>
+MESSAGE_LIST = {
+    -- shop messages
+    needMoney = "You need more money",
+    needSpace = "You do not have enough capacity.",
+    needMoreSpace = "You do not have enough capacity for all items.",
+    bought = "You bought |ITEMCOUNT| |ITEMNAME|(s) for |TOTALCOST| gold.",
+    sold = "You sold |ITEMCOUNT| |ITEMNAME|(s) for |TOTALCOST| gold.",
+    -- requirement cancel messages
+    storage = "You do not meet the storage requirement.",
+    storageNotEqual = "You do not meet the storage requirement.",
+    storageToLow = "You do not meet the storage requirement.",
+    storageToHigh = "You do not meet the storage requirement.",
+    level = "You need to be exactly level |PLAYERLEVEL|.",
+    levelNotEqual = "You can't be exactly level |PLAYERLEVEL|.",
+    levelToLow = "You need to be atleast level |PLAYERLEVEL|.",
+    levelToHigh = "You need to be under level |PLAYERLEVEL|.",
+    premium = "You need to be premium to do this.",
+    money = "You do not have enough money, it costs |TOTALCOST| gold.",
+    item = "You do not have atleast |ITEMCOUNT| |ITEMNAME|(s).",
+    infight = "You need to be in fight.",
+    notInfight = "You have to be out of fight.",
+    pzLocked = "You need to be pz locked",
+    notPzLocked = "You are not allowed to be pz locked"
+}
+
+-- KEYWORDS_GREET
+---@type string[]
+KEYWORDS_GREET = {
+    "hi",
+    "hello",
+    "hey",
+    "greetings"
+}
+
+-- MESSAGES_GREET
+---@type string[]
+MESSAGES_GREET = {
+    "Hello |PLAYERNAME| how can I help you?",
+    "Greetings |PLAYERNAME|, what can I do for you?",
+    "Hi |PLAYERNAME|, what's your desire today?"
+}
+
+-- KEYWORDS_FAREWELL
+---@type string[]
+KEYWORDS_FAREWELL = {
+    "bye",
+    "goodbye",
+    "farewell",
+    "cya",
+    "ciao"
+}
+
+-- MESSAGES_FAREWELL
+---@type string[]
+MESSAGES_FAREWELL = {
+    "Goodbye |PLAYERNAME|, have a nice day!",
+    "Farewell |PLAYERNAME|, see you soon!",
+    "See you later |PLAYERNAME|, take care!"
+}
+
+-- FOCUS
+---@class FOCUS
+---@type table<string, any>
+FOCUS = {
+    -- how long the npc will focus the player in seconds
+    time = 60,
+    -- how far the player can step away until the npc loses focus
+    distance = 5,
+    -- how near the player has to be to greet the npc
+    greetDistance = 3
+}
+
+-- TALK
+---@class TALK
+---@type table<string, any>
+TALK = {
+    -- how long in ms the npc will wait before responding
+    defaultDelay = 1000
+}
+
+REQUIREMENTS = {
+    storage = 1,
+    level = 2,
+    premium = 3,
+    money = 4,
+    item = 5,
+    inFight = 6,
+    pzLocked= 7,
+    removeItem = 8
+}