Remove some TODOs

otovo · Mar 18, 2017 · 5e91c89 · 5e91c89
1 parent 24c67ce
commit 5e91c89
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/netsgiro/records.py b/netsgiro/records.py
@@ -415,7 +415,7 @@ def to_ocr(self) -> str:
                 '{self.centre_id:2}'
                 '{self.day_code:02d}'
                 '{self.partial_settlement_number:01d}'
-                '{self.partial_settlement_serial_number:5}'  # TODO int?
+                '{self.partial_settlement_serial_number:5}'
                 '{self.sign:1}'
             ).format(self=self)
         else:
@@ -465,7 +465,7 @@ class TransactionAmountItem2(TransactionRecord):
             (?P<form_number>\d{10})
             (?P<reference>\d{9})
 
-            .{7} # Filler   # TODO Not always zero in test data
+            .{7} # Filler   # XXX Not always filled with zero in test data
 
             (?P<bank_date>\d{6})
             (?P<debit_account>\d{11})

diff --git a/tests/test_record_parsing.py b/tests/test_record_parsing.py
@@ -245,7 +245,7 @@ def test_transaction_amount_item_1_for_ocr_giro_transactions():
     assert record.day_code == 20
     assert record.partial_settlement_number == 1
     assert record.partial_settlement_serial_number == '01464'
-    assert record.sign == '0'  # TODO Change type?
+    assert record.sign == '0'
 
     assert record.amount == 102000
     assert record.kid == '0000531'