-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message events #166
Comments
Ok, so we don't necessarily need them; but message events are used, from a client level, to generate notifications to the user, like the ones stated here: otrv4/pidgin-otrng#49 We can also tweak what we have to generate the same thing, though... |
Ah, I see. Yeah, those notifications are useful to have, and events definitely feel like the cleanest way of doing them. Do you have alternatives? Otherwise I think this is good. |
Well, in libotr, message events are handled in the "top" sending and receiving funcs. So when, for example, a hearbeat message is sent, the event is also raised:
Our code is different, and we don't have major functions that handle everything; but rather small functions, like this:
my idea is that there we can create a callback
which is used every time an error message is received:
We can use the same callback for every event required:
What do you think? |
Ok, I have added most of them. I need to document and check if we will support the other ones. |
I'll stop the work on this until we have the groups of policies in place. |
Finished now. |
We can use:
The text was updated successfully, but these errors were encountered: