Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better initial preview experience #136

Closed
otsaloma opened this issue Jul 20, 2019 · 1 comment
Closed

Better initial preview experience #136

otsaloma opened this issue Jul 20, 2019 · 1 comment

Comments

@otsaloma
Copy link
Owner

  • Check which players are installed
  • Try to default to a player that's available
  • Make the preview error dialog more helpful
otsaloma added a commit that referenced this issue Jul 28, 2019
@otsaloma
Try to default to a video player that's available
ff9a5a6 
Part of #136
otsaloma added a commit that referenced this issue Jul 29, 2019
@otsaloma
Improve preview error dialogs
0104275 
Check if player is found before running command and, if not, show a
simpler and clearer error dialog. Note that aeidon.ProcessError doesn't
seem to ever be fired here due to the process being run via a shell
(non-win32 systems, for reasons that I don't recall). In the preview
error dialog also point to the preferences dialog.

Part of #136
@otsaloma
Copy link
Owner Author

Should be done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@otsaloma