Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ignore params in potentials #322

Closed
michalk8 opened this issue Feb 28, 2023 · 0 comments · Fixed by #325
Closed

Don't ignore params in potentials #322

michalk8 opened this issue Feb 28, 2023 · 0 comments · Fixed by #325
Assignees
@michalk8

Comments

@michalk8
Copy link
Collaborator 

          `params` here are for initialization and shouldn't be ignored, they're passed into `NeuralTrainState.create`

Originally posted by @bamos in #319 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalk8 michalk8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ignoring passed params in ICNN michalk8/ott
1 participant
@michalk8