Enable D* checks
#319
Merged
Enable D* checks
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 88.78% 88.82% +0.04%
==========================================
Files 52 52
Lines 5715 5657 -58
Branches 587 863 +276
==========================================
- Hits 5074 5025 -49
+ Misses 513 506 -7
+ Partials 128 126 -2
|
michalk8
commented
Feb 27, 2023
| @@ -292,6 +286,7 @@ def create_train_state( | |||
| rng: jax.random.PRNGKeyArray, | |||
| optimizer: optax.OptState, | |||
| input: Union[int, Tuple[int, ...]], | |||
| # TODO(michalk8): do not ignore or delete in code? | |||
There was a problem hiding this comment.
@bamos are the params supposed to be ignored?
There was a problem hiding this comment.
params here are for initialization and shouldn't be ignored, they're passed into NeuralTrainState.create
michalk8
added a commit
that referenced
this pull request
Jun 27, 2024
* Re-enable D* flake8
* Fix `D*` errors
* Do not ignore D411
* Remove ignored `F401`
* Enable `B008`, add `optax` to `intersphinx_mapping`
* Remove old `.flake8` config
* Add `SortingInitializer` to docs
* Enable `E501`
* Fix docs in `{costs,geometry}.py`
* Update `pointcloud.py`
* Fix `initializers.py`
* Fix `matrix_square_root.py`
* Fix `unbalanced_functions.py`
* Fix more docstrings, add missing licenses
* Fix typo in `FreeWassersteinBarycenter`
* Fix `sinkhorn_lr.py`
* Fix `models.py`
* Fix `neuraldual.py`
* Fix `gromov_wasserstein.py`
* Fix `plot.py`
* Fix `tests/`
* Fix `utils.py`
* Fix `k_means.py`
* Fix `gaussian.py`
* Fix `fit_gmm_pair.py`
* Fix typo
* Make `create_sample_generators` private
* Unable more flake8's in docs
* Add more testing flake8
* Add `SIM`
* Add `RET`
* Undo adding docs
* Add more type hints
* Use double quotes always
* Add explicit quotes normalization
* Udpate comment
* Remove commented flake8s in `pyproject.toml`
* Fix typo in typing
* Skip graph factor cache test
* Fix float in test instead of an integer
* Improve `CostFn` docstring
* Update `pairwise` docs
* Remove `[d,]` from docs
* [ci skip] Mention `gamma > 0`
* Remove module docs, add missing copyright
* [ci skip] Fix docs rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"and add many additional checksjax.pure_callback#257closes Enable and fix
D*linter checks #315