Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Soft-DTW cost function #318

Merged
merged 15 commits into from
Feb 27, 2023
Merged

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Feb 24, 2023

Also polish the references.bib, in the future, include the Sakoe-Chiba band.

@michalk8 michalk8 added the enhancement New feature or request label Feb 24, 2023
@michalk8 michalk8 self-assigned this Feb 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #318 (84e218b) into main (05ff6dd) will increase coverage by 0.05%.
The diff coverage is 95.55%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   88.76%   88.81%   +0.05%     
==========================================
  Files          52       52              
  Lines        5670     5715      +45     
  Branches      859      865       +6     
==========================================
+ Hits         5033     5076      +43     
- Misses        509      511       +2     
  Partials      128      128              
Impacted Files Coverage Δ
src/ott/geometry/costs.py 98.58% <95.00%> (-0.46%) ⬇️
src/ott/math/utils.py 93.87% <100.00%> (+0.69%) ⬆️

pyproject.toml Outdated Show resolved Hide resolved
@michalk8 michalk8 merged commit b18f9fb into ott-jax:main Feb 27, 2023
@michalk8 michalk8 deleted the feature/soft-dtw-cost branch February 27, 2023 18:41
michalk8 added a commit that referenced this pull request Jun 27, 2024
* Add initial `SoftDTW` cost matrix

* Add tree flatten

* Fix typo

* Add custom vjps

* Add debiased `SoftDTW`

* Update pre-commits

* Add citations

* Format references

* Add tests

* Add `axis` to `softmin`, add docstring

* Update docstring

* Unpack

* Skip `tslearn` on `Python3.11`

* Revert test requirements specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants