Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when instatiating cost/kernel for a grid #565

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

michalk8
Copy link
Collaborator

closes #561

@michalk8 michalk8 self-assigned this Jul 22, 2024
@michalk8 michalk8 added the misc label Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (2b866d3) to head (1de6ce1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   89.45%   89.46%           
=======================================
  Files          71       71           
  Lines        7550     7554    +4     
  Branches     1075     1077    +2     
=======================================
+ Hits         6754     6758    +4     
  Misses        645      645           
  Partials      151      151           
Files Coverage Δ
src/ott/geometry/grid.py 95.45% <100.00%> (+0.14%) ⬆️

@michalk8 michalk8 merged commit 7dcc09c into main Jul 22, 2024
11 of 12 checks passed
@michalk8 michalk8 deleted the fix/grid-kernel-cost-error branch July 22, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compute cost_matrix or kernel_matrix from geometry.grid.Grid if both set to None
1 participant