New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLA-221 Rework PullRequestTest to work with non npm package managers #264
PLA-221 Rework PullRequestTest to work with non npm package managers #264
Conversation
src/common/github/run-script-job.ts
Outdated
/** | ||
* Create GitHub workflow job which runs a node.js script with a given setup. | ||
*/ | ||
export const runScriptJob = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This jobs completely replicates the npm-run
action and adds functionality to work not only with npm, but rather pnpm and yarn.
@quesabe can we release it to |
@gvidon, I guess we can. The workflow we have does not support such a variety, but I can do it manually. BTW do we expect canaries to be rarely used or not? If we want a long lasting solution for canary releases maybe I should create a branch Please let me know which path you consider more suitable. |
@quesabe for now we don't plan frequent canaries, so lets go with manual solution. Please ping @igorosip0v on Slack when it is published. |
Add a run-script-job that sets up a generic workflow capable of working with npm, pnpm and yarn; update the PullRequestTest workflow to use the new jobs; update tests and templates accordingly.
9bb7d71
to
493d5b9
Compare
Move the setup steps into a separate function in order to reuse the steps in lighthouse job. Update typings.
493d5b9
to
0aab936
Compare
Closes PLA-221.
Previous to this PR the test workflow can only operate with
npm
. In order to make it work with other package managers the following was done:npm-run
action to a manually composed job with all steps replicating thenpm-run
action - the function is namedsetupNode
; the node setup is configurable to be capable of working withnpm
,pnpm
andyarn
(with the help ofprojen
internals).runScriptJob
function that sets up a generic workflow job with thesetupNode
steps and a final command being run afterwards;setupNode
for lighthouse audit setup;PullRequestTest
workflow to use the new functionality;